lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <3df2007f-acd2-4cd1-8f96-8ebd6070770a@app.fastmail.com> Date: Mon, 24 Oct 2022 22:47:02 +0200 From: "Arnd Bergmann" <arnd@...db.de> To: "Geert Uytterhoeven" <geert@...ux-m68k.org> Cc: "kernel test robot" <lkp@...el.com>, "Yoshihiro Shimoda" <yoshihiro.shimoda.uh@...esas.com>, "David S . Miller" <davem@...emloft.net>, "Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>, "Paolo Abeni" <pabeni@...hat.com>, "Rob Herring" <robh+dt@...nel.org>, krzysztof.kozlowski+dt@...aro.org, kbuild-all@...ts.01.org, Netdev <netdev@...r.kernel.org>, devicetree@...r.kernel.org, Linux-Renesas <linux-renesas-soc@...r.kernel.org> Subject: Re: [PATCH v4 2/3] net: ethernet: renesas: Add Ethernet Switch driver On Mon, Oct 24, 2022, at 22:35, Geert Uytterhoeven wrote: >> >> Regardless of which way this is expressed, it looked like there is >> a missing __le32_to_cpu() around the high word. > > I think it's OK, because desc->dptrh is u8: > > struct rswitch_desc { > __le16 info_ds; /* Descriptor size */ > u8 die_dt; /* Descriptor interrupt enable and type */ > __u8 dptrh; /* Descriptor pointer MSB */ > __le32 dptrl; /* Descriptor pointer LSW */ > } __packed; Right, that makes sense. On a completely unrelated note, you might want to remove the __packed annotation though, as the compiler might otherwise use bytewise access to the dptrl field instead of a word access, which would cause some overhead in case this is in uncached memory. Arnd
Powered by blists - more mailing lists