netdev - Re: [PATCH v4 2/3] net: ethernet: renesas: Add Ethernet Switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Oct 2022 16:04:05 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org,
        Vladimir Oltean <olteanv@...il.com>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v4 2/3] net: ethernet: renesas: Add Ethernet Switch driver

On 10/20/22 07:11, Andrew Lunn wrote:
> On Wed, Oct 19, 2022 at 07:23:26PM -0700, Florian Fainelli wrote:
>>
>>
>> On 10/19/2022 1:35 AM, Yoshihiro Shimoda wrote:
>>> Add Renesas Ethernet Switch driver for R-Car S4-8 to be used as an
>>> ethernet controller.
>>>
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
>>
>> How can this be a switch driver when it does not include any switchdev
>> header files nor does it attempt to be using the DSA framework? You are
>> certainly duplicating a lot of things that DSA would do for you like
>> managing PHYs and registering per-port nework devices. Why?
> 
> Hi Florian
> 
> It is not clear yet if this is actually a DSA switch. I asked these
> questions a few revisions ago and it actually looks like it is a pure
> switchdev switch. It might be possible to make it a DSA switch. It is
> a bit fuzzy, since it is all internal and integrated.

We were dealing with an integrated Ethernet MAC and switch back in 2014 
when DSA was resurrected to support bcm_sf2 + bcmsysport, also, we are 
about to get support for in-band DSA tags with Maxime's patch series.

I suppose that as long as the binding is conforming, we can always make 
the driver evolve, it would be good to see all of the pieces now though.
-- 
Florian