lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Oct 2022 09:34:41 +0000 From: Biju Das <biju.das.jz@...renesas.com> To: Marc Kleine-Budde <mkl@...gutronix.de> CC: Wolfgang Grandegger <wg@...ndegger.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Vincent Mailhol <mailhol.vincent@...adoo.fr>, Stefan Mätje <stefan.maetje@....eu>, Ulrich Hecht <uli+renesas@...nd.eu>, Fabrizio Castro <fabrizio.castro.jz@...esas.com>, Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>, Oliver Hartkopp <socketcan@...tkopp.net>, Christophe JAILLET <christophe.jaillet@...adoo.fr>, "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Geert Uytterhoeven <geert+renesas@...der.be>, Chris Paterson <Chris.Paterson2@...esas.com>, "linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org> Subject: RE: [PATCH v2 2/3] can: rcar_canfd: Fix channel specific IRQ handling for RZ/G2L Hi Marc, Thanks for the review. > Subject: Re: [PATCH v2 2/3] can: rcar_canfd: Fix channel specific IRQ > handling for RZ/G2L > > On 25.10.2022 16:56:56, Biju Das wrote: > > RZ/G2L has separate channel specific IRQs for transmit and error > > interrupt. But the IRQ handler, process the code for both channels > > even if there is no interrupt occurred on one of the channels. > > > > This patch fixes the issue by passing channel specific context > > parameter instead of global one for irq register and on irq handler, > > it just handles the channel which is triggered the interrupt. > > Please clean up signatures of the IRQ handlers you touch, it's a > little mess. Change: > > | rcar_canfd_handle_channel_tx(struct rcar_canfd_global *gpriv, u32 > ch) > > to: > > | rcar_canfd_handle_channel_tx(struct rcar_canfd_channel *priv) > > Same for: > > | static void rcar_canfd_handle_channel_err(struct rcar_canfd_global > | *gpriv, u32 ch) > OK. > > > In a separate patch, please clean up these, too: > > | static void rcar_canfd_handle_global_err(struct rcar_canfd_global > | *gpriv, u32 ch) static void rcar_canfd_handle_global_receive(struct > | rcar_canfd_global *gpriv, u32 ch) static void > | rcar_canfd_channel_remove(struct rcar_canfd_global *gpriv, u32 ch) > > Why are 2 of the above functions called "global" as they work on a > specific channel? That can be streamlined, too. > The function name is as per the hardware manual, Interrupt sources are classified into global and channel interrupts. • Global interrupts (2 sources): — Receive FIFO interrupt — Global error interrupt • Channel interrupts (3 sources/channel): Maybe we could change "rcar_canfd_handle_global_receive"->"rcar_canfd_handle_channel_receive", as from driver point It is not global anymore?? Please let me know. Cheers, Biju
Powered by blists - more mailing lists