netdev - Re: [External] : Re: [PATCH 1/1] IB/mlx5: Add a signature check to received EQEs and CQEs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Oct 2022 15:23:20 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Rohit Nair <rohit.sajan.kumar@...cle.com>
Cc:     jgg@...pe.ca, saeedm@...dia.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, manjunath.b.patil@...cle.com,
        rama.nichanamatlu@...cle.com,
        Michael Guralnik <michaelgur@...dia.com>
Subject: Re: [External] : Re: [PATCH 1/1] IB/mlx5: Add a signature check to
 received EQEs and CQEs

On Tue, Oct 25, 2022 at 10:44:12AM -0700, Rohit Nair wrote:
> Hey Leon,
> 
> Please find my replies to your comments here below:

<...>

> > 
> > > This patch does not introduce any significant performance degradations
> > > and has been tested using qperf.
> > What does it mean? You made changes in kernel verbs flow, they are not
> > executed through qperf.
> We also conducted several extensive performance tests using our test-suite
> which utilizes rds-stress and also saw no significant performance
> degrdations in those results.

What does it mean "also"? Your change is applicable ONLY for kernel path.

Anyway, I'm not keen adding rare debug code to performance critical path.

Thanks