lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y1sQ4tdhYzvNwrZJ@lunn.ch> Date: Fri, 28 Oct 2022 01:14:42 +0200 From: Andrew Lunn <andrew@...n.ch> To: David Thompson <davthompson@...dia.com> Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org, cai.huoqing@...ux.dev, brgl@...ev.pl, limings@...dia.com, Asmaa Mnebhi <asmaa@...dia.com> Subject: Re: [PATCH net-next v1 2/4] mlxbf_gige: support 10M/100M/1G speeds on BlueField-3 > +static void mlxbf_gige_bf3_adjust_link(struct net_device *netdev) > +{ > + struct mlxbf_gige *priv = netdev_priv(netdev); > + struct phy_device *phydev = netdev->phydev; > + unsigned long flags; > + u8 sgmii_mode; > + u16 ipg_size; > + u32 val; > + > + spin_lock_irqsave(&priv->lock, flags); What are you protecting with this spinlock? phylib holds the phy mutex while it calls the adjust_link method, so calls to it are serialised. Andrew
Powered by blists - more mailing lists