netdev - Re: [PATCH net-next v1 3/4] mlxbf_gige: add BlueField-3 Serdes configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1sTc8zJ7bCN85bK@lunn.ch>
Date:   Fri, 28 Oct 2022 01:25:39 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     David Thompson <davthompson@...dia.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org, cai.huoqing@...ux.dev,
        brgl@...ev.pl, limings@...dia.com, Asmaa Mnebhi <asmaa@...dia.com>
Subject: Re: [PATCH net-next v1 3/4] mlxbf_gige: add BlueField-3 Serdes
 configuration

> +mlxbf_gige_clm_init[] = {
> +	{.addr = 0x001, .wdata = 0x0105},
> +	{.addr = 0x008, .wdata = 0x0001},
> +	{.addr = 0x00B, .wdata = 0x8420},
> +	{.addr = 0x00E, .wdata = 0x0110},
> +	{.addr = 0x010, .wdata = 0x3010},
> +	{.addr = 0x027, .wdata = 0x0104},
> +	{.addr = 0x02F, .wdata = 0x09EA},
> +	{.addr = 0x055, .wdata = 0x0008},
> +	{.addr = 0x058, .wdata = 0x0088},
> +	{.addr = 0x072, .wdata = 0x3222},
> +	{.addr = 0x073, .wdata = 0x7654},
> +	{.addr = 0x074, .wdata = 0xBA98},
> +	{.addr = 0x075, .wdata = 0xDDDC}
> +};
> +
> +#define MLXBF_GIGE_UPHY_CLM_INIT_NUM_ENTRIES \
> +	(sizeof(mlxbf_gige_clm_init) / sizeof(struct mlxbf_gige_uphy_cfg_reg))

ARRAY_SIZE() ?

You have a lot of completely undocumented black magic here. And these
tables are quite large. I'm wondering if it really should be
considered firmware, and loaded on demand from /lib/firmware ?

	   Andrew