netdev - Re: [PATCH net-next v1 4/4] mlxbf_gige: add BlueField-3 ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1sURRYUzwDCbpjX@lunn.ch>
Date:   Fri, 28 Oct 2022 01:29:09 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     David Thompson <davthompson@...dia.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org, cai.huoqing@...ux.dev,
        brgl@...ev.pl, limings@...dia.com, Asmaa Mnebhi <asmaa@...dia.com>
Subject: Re: [PATCH net-next v1 4/4] mlxbf_gige: add BlueField-3 ethtool_ops

On Thu, Oct 27, 2022 at 06:00:13PM -0400, David Thompson wrote:
> This patch adds logic to support initialization of a
> BlueField-3 specific "ethtool_ops" data structure. The
> BlueField-3 data structure supports the "set_link_ksettings"
> callback, while the BlueField-2 data structure does not.

Why?

I _think_, so long as the supported values have been set correctly in
the phydev, set_link_ksettings should not be able to set anything for
BF2 which it cannot support.

    Andrew