| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Oct 2022 09:20:22 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
"Czapnik, Lukasz" <lukasz.czapnik@...el.com>
CC: Jakub Kicinski <kuba@...nel.org>,
David Miller <davem@...emloft.net>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"Palczewski, Mateusz" <mateusz.palczewski@...el.com>,
"G, GurucharanX" <gurucharanx.g@...el.com>
Subject: RE: [PATCH net-next] ice: Add additional CSR registers
> -----Original Message-----
> From: Fijalkowski, Maciej <maciej.fijalkowski@...el.com>
> Sent: Wednesday, October 26, 2022 7:55 AM
> To: Keller, Jacob E <jacob.e.keller@...el.com>
> Cc: Jakub Kicinski <kuba@...nel.org>; David Miller <davem@...emloft.net>;
> netdev@...r.kernel.org; Czapnik, Lukasz <lukasz.czapnik@...el.com>;
> Palczewski, Mateusz <mateusz.palczewski@...el.com>; G, GurucharanX
> <gurucharanx.g@...el.com>
> Subject: Re: [PATCH net-next] ice: Add additional CSR registers
>
> On Wed, Oct 26, 2022 at 04:28:39AM -0700, Jacob Keller wrote:
> > From: Lukasz Czapnik <lukasz.czapnik@...el.com>
> >
> > Add additional CSR registers that will provide more information
> > in the dump that occurs after Tx hang.
>
> So...where is the corresponding commit that would actually utilize some of
> these additional regs? :p
>
I'm not sure I follow your question. This commit adds the registers to the ice_regs_dump_list which is used by ice_get_regs_len and ice_get_regs, meaning that their contents will be output when you dump registers using ETHTOOL_GREGS. We don't need any other driver side work to "use" these as its just extending the table of what gets dumped.
I guess we could extend the userspace program to include the set of registers along with useful names? @Czapnik, Lukasz do you have such a patch prepared?
Thanks,
Jake
> >
> > Signed-off-by: Lukasz Czapnik <lukasz.czapnik@...el.com>
> > Signed-off-by: Mateusz Palczewski <mateusz.palczewski@...el.com>
> > Tested-by: Gurucharan <gurucharanx.g@...el.com> (A Contingent worker at
> Intel)
> > ---
> > drivers/net/ethernet/intel/ice/ice_ethtool.c | 169 +++++++++++++++++++
> > 1 file changed, 169 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c
> b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> > index b7be84bbe72d..f71a7521c7bd 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> > @@ -151,6 +151,175 @@ static const u32 ice_regs_dump_list[] = {
> > QINT_RQCTL(0),
> > PFINT_OICR_ENA,
> > QRX_ITR(0),
> > +#define GLDCB_TLPM_PCI_DM 0x000A0180
> > + GLDCB_TLPM_PCI_DM,
> > +#define GLDCB_TLPM_TC2PFC 0x000A0194
> > + GLDCB_TLPM_TC2PFC,
> > +#define TCDCB_TLPM_WAIT_DM(_i) (0x000A0080 + ((_i) * 4))
> > + TCDCB_TLPM_WAIT_DM(0),
> > + TCDCB_TLPM_WAIT_DM(1),
> > + TCDCB_TLPM_WAIT_DM(2),
> > + TCDCB_TLPM_WAIT_DM(3),
> > + TCDCB_TLPM_WAIT_DM(4),
> > + TCDCB_TLPM_WAIT_DM(5),
> > + TCDCB_TLPM_WAIT_DM(6),
> > + TCDCB_TLPM_WAIT_DM(7),
> > + TCDCB_TLPM_WAIT_DM(8),
> > + TCDCB_TLPM_WAIT_DM(9),
> > + TCDCB_TLPM_WAIT_DM(10),
> > + TCDCB_TLPM_WAIT_DM(11),
> > + TCDCB_TLPM_WAIT_DM(12),
> > + TCDCB_TLPM_WAIT_DM(13),
> > + TCDCB_TLPM_WAIT_DM(14),
> > + TCDCB_TLPM_WAIT_DM(15),
> > + TCDCB_TLPM_WAIT_DM(16),
> > + TCDCB_TLPM_WAIT_DM(17),
> > + TCDCB_TLPM_WAIT_DM(18),
> > + TCDCB_TLPM_WAIT_DM(19),
> > + TCDCB_TLPM_WAIT_DM(20),
> > + TCDCB_TLPM_WAIT_DM(21),
> > + TCDCB_TLPM_WAIT_DM(22),
> > + TCDCB_TLPM_WAIT_DM(23),
> > + TCDCB_TLPM_WAIT_DM(24),
> > + TCDCB_TLPM_WAIT_DM(25),
> > + TCDCB_TLPM_WAIT_DM(26),
> > + TCDCB_TLPM_WAIT_DM(27),
> > + TCDCB_TLPM_WAIT_DM(28),
> > + TCDCB_TLPM_WAIT_DM(29),
> > + TCDCB_TLPM_WAIT_DM(30),
> > + TCDCB_TLPM_WAIT_DM(31),
> > +#define GLPCI_WATMK_CLNT_PIPEMON 0x000BFD90
> > + GLPCI_WATMK_CLNT_PIPEMON,
> > +#define GLPCI_CUR_CLNT_COMMON 0x000BFD84
> > + GLPCI_CUR_CLNT_COMMON,
> > +#define GLPCI_CUR_CLNT_PIPEMON 0x000BFD88
> > + GLPCI_CUR_CLNT_PIPEMON,
> > +#define GLPCI_PCIERR 0x0009DEB0
> > + GLPCI_PCIERR,
> > +#define GLPSM_DEBUG_CTL_STATUS 0x000B0600
> > + GLPSM_DEBUG_CTL_STATUS,
> > +#define GLPSM0_DEBUG_FIFO_OVERFLOW_DETECT 0x000B0680
> > + GLPSM0_DEBUG_FIFO_OVERFLOW_DETECT,
> > +#define GLPSM0_DEBUG_FIFO_UNDERFLOW_DETECT 0x000B0684
> > + GLPSM0_DEBUG_FIFO_UNDERFLOW_DETECT,
> > +#define GLPSM0_DEBUG_DT_OUT_OF_WINDOW 0x000B0688
> > + GLPSM0_DEBUG_DT_OUT_OF_WINDOW,
> > +#define GLPSM0_DEBUG_INTF_HW_ERROR_DETECT 0x000B069C
> > + GLPSM0_DEBUG_INTF_HW_ERROR_DETECT,
> > +#define GLPSM0_DEBUG_MISC_HW_ERROR_DETECT 0x000B06A0
> > + GLPSM0_DEBUG_MISC_HW_ERROR_DETECT,
> > +#define GLPSM1_DEBUG_FIFO_OVERFLOW_DETECT 0x000B0E80
> > + GLPSM1_DEBUG_FIFO_OVERFLOW_DETECT,
> > +#define GLPSM1_DEBUG_FIFO_UNDERFLOW_DETECT 0x000B0E84
> > + GLPSM1_DEBUG_FIFO_UNDERFLOW_DETECT,
> > +#define GLPSM1_DEBUG_SRL_FIFO_OVERFLOW_DETECT 0x000B0E88
> > + GLPSM1_DEBUG_SRL_FIFO_OVERFLOW_DETECT,
> > +#define GLPSM1_DEBUG_SRL_FIFO_UNDERFLOW_DETECT 0x000B0E8C
> > + GLPSM1_DEBUG_SRL_FIFO_UNDERFLOW_DETECT,
> > +#define GLPSM1_DEBUG_MISC_HW_ERROR_DETECT 0x000B0E90
> > + GLPSM1_DEBUG_MISC_HW_ERROR_DETECT,
> > +#define GLPSM2_DEBUG_FIFO_OVERFLOW_DETECT 0x000B1680
> > + GLPSM2_DEBUG_FIFO_OVERFLOW_DETECT,
> > +#define GLPSM2_DEBUG_FIFO_UNDERFLOW_DETECT 0x000B1684
> > + GLPSM2_DEBUG_FIFO_UNDERFLOW_DETECT,
> > +#define GLPSM2_DEBUG_MISC_HW_ERROR_DETECT 0x000B1688
> > + GLPSM2_DEBUG_MISC_HW_ERROR_DETECT,
> > +#define GLTDPU_TCLAN_COMP_BOB(_i) (0x00049ADC + ((_i) * 4))
> > + GLTDPU_TCLAN_COMP_BOB(1),
> > + GLTDPU_TCLAN_COMP_BOB(2),
> > + GLTDPU_TCLAN_COMP_BOB(3),
> > + GLTDPU_TCLAN_COMP_BOB(4),
> > + GLTDPU_TCLAN_COMP_BOB(5),
> > + GLTDPU_TCLAN_COMP_BOB(6),
> > + GLTDPU_TCLAN_COMP_BOB(7),
> > + GLTDPU_TCLAN_COMP_BOB(8),
> > +#define GLTDPU_TCB_CMD_BOB(_i) (0x0004975C + ((_i) * 4))
> > + GLTDPU_TCB_CMD_BOB(1),
> > + GLTDPU_TCB_CMD_BOB(2),
> > + GLTDPU_TCB_CMD_BOB(3),
> > + GLTDPU_TCB_CMD_BOB(4),
> > + GLTDPU_TCB_CMD_BOB(5),
> > + GLTDPU_TCB_CMD_BOB(6),
> > + GLTDPU_TCB_CMD_BOB(7),
> > + GLTDPU_TCB_CMD_BOB(8),
> > +#define GLTDPU_PSM_UPDATE_BOB(_i) (0x00049B5C + ((_i) * 4))
> > + GLTDPU_PSM_UPDATE_BOB(1),
> > + GLTDPU_PSM_UPDATE_BOB(2),
> > + GLTDPU_PSM_UPDATE_BOB(3),
> > + GLTDPU_PSM_UPDATE_BOB(4),
> > + GLTDPU_PSM_UPDATE_BOB(5),
> > + GLTDPU_PSM_UPDATE_BOB(6),
> > + GLTDPU_PSM_UPDATE_BOB(7),
> > + GLTDPU_PSM_UPDATE_BOB(8),
> > +#define GLTCB_CMD_IN_BOB(_i) (0x000AE288 + ((_i) * 4))
> > + GLTCB_CMD_IN_BOB(1),
> > + GLTCB_CMD_IN_BOB(2),
> > + GLTCB_CMD_IN_BOB(3),
> > + GLTCB_CMD_IN_BOB(4),
> > + GLTCB_CMD_IN_BOB(5),
> > + GLTCB_CMD_IN_BOB(6),
> > + GLTCB_CMD_IN_BOB(7),
> > + GLTCB_CMD_IN_BOB(8),
> > +#define GLLAN_TCLAN_FETCH_CTL_FBK_BOB_CTL(_i) (0x000FC148 + ((_i) *
> 4))
> > + GLLAN_TCLAN_FETCH_CTL_FBK_BOB_CTL(1),
> > + GLLAN_TCLAN_FETCH_CTL_FBK_BOB_CTL(2),
> > + GLLAN_TCLAN_FETCH_CTL_FBK_BOB_CTL(3),
> > + GLLAN_TCLAN_FETCH_CTL_FBK_BOB_CTL(4),
> > + GLLAN_TCLAN_FETCH_CTL_FBK_BOB_CTL(5),
> > + GLLAN_TCLAN_FETCH_CTL_FBK_BOB_CTL(6),
> > + GLLAN_TCLAN_FETCH_CTL_FBK_BOB_CTL(7),
> > + GLLAN_TCLAN_FETCH_CTL_FBK_BOB_CTL(8),
> > +#define GLLAN_TCLAN_FETCH_CTL_SCHED_BOB_CTL(_i) (0x000FC248 + ((_i) *
> 4))
> > + GLLAN_TCLAN_FETCH_CTL_SCHED_BOB_CTL(1),
> > + GLLAN_TCLAN_FETCH_CTL_SCHED_BOB_CTL(2),
> > + GLLAN_TCLAN_FETCH_CTL_SCHED_BOB_CTL(3),
> > + GLLAN_TCLAN_FETCH_CTL_SCHED_BOB_CTL(4),
> > + GLLAN_TCLAN_FETCH_CTL_SCHED_BOB_CTL(5),
> > + GLLAN_TCLAN_FETCH_CTL_SCHED_BOB_CTL(6),
> > + GLLAN_TCLAN_FETCH_CTL_SCHED_BOB_CTL(7),
> > + GLLAN_TCLAN_FETCH_CTL_SCHED_BOB_CTL(8),
> > +#define GLLAN_TCLAN_CACHE_CTL_BOB_CTL(_i) (0x000FC1C8 + ((_i) * 4))
> > + GLLAN_TCLAN_CACHE_CTL_BOB_CTL(1),
> > + GLLAN_TCLAN_CACHE_CTL_BOB_CTL(2),
> > + GLLAN_TCLAN_CACHE_CTL_BOB_CTL(3),
> > + GLLAN_TCLAN_CACHE_CTL_BOB_CTL(4),
> > + GLLAN_TCLAN_CACHE_CTL_BOB_CTL(5),
> > + GLLAN_TCLAN_CACHE_CTL_BOB_CTL(6),
> > + GLLAN_TCLAN_CACHE_CTL_BOB_CTL(7),
> > + GLLAN_TCLAN_CACHE_CTL_BOB_CTL(8),
> > +#define GLLAN_TCLAN_FETCH_CTL_PROC_BOB_CTL(_i) (0x000FC188 + ((_i) *
> 4))
> > + GLLAN_TCLAN_FETCH_CTL_PROC_BOB_CTL(1),
> > + GLLAN_TCLAN_FETCH_CTL_PROC_BOB_CTL(2),
> > + GLLAN_TCLAN_FETCH_CTL_PROC_BOB_CTL(3),
> > + GLLAN_TCLAN_FETCH_CTL_PROC_BOB_CTL(4),
> > + GLLAN_TCLAN_FETCH_CTL_PROC_BOB_CTL(5),
> > + GLLAN_TCLAN_FETCH_CTL_PROC_BOB_CTL(6),
> > + GLLAN_TCLAN_FETCH_CTL_PROC_BOB_CTL(7),
> > + GLLAN_TCLAN_FETCH_CTL_PROC_BOB_CTL(8),
> > +#define GLLAN_TCLAN_FETCH_CTL_PCIE_RD_BOB_CTL(_i) (0x000FC288 + ((_i)
> * 4))
> > + GLLAN_TCLAN_FETCH_CTL_PCIE_RD_BOB_CTL(1),
> > + GLLAN_TCLAN_FETCH_CTL_PCIE_RD_BOB_CTL(2),
> > + GLLAN_TCLAN_FETCH_CTL_PCIE_RD_BOB_CTL(3),
> > + GLLAN_TCLAN_FETCH_CTL_PCIE_RD_BOB_CTL(4),
> > + GLLAN_TCLAN_FETCH_CTL_PCIE_RD_BOB_CTL(5),
> > + GLLAN_TCLAN_FETCH_CTL_PCIE_RD_BOB_CTL(6),
> > + GLLAN_TCLAN_FETCH_CTL_PCIE_RD_BOB_CTL(7),
> > + GLLAN_TCLAN_FETCH_CTL_PCIE_RD_BOB_CTL(8),
> > +#define PRTDCB_TCUPM_REG_CM(_i) (0x000BC360 +
> ((_i) * 4))
> > + PRTDCB_TCUPM_REG_CM(0),
> > + PRTDCB_TCUPM_REG_CM(1),
> > + PRTDCB_TCUPM_REG_CM(2),
> > + PRTDCB_TCUPM_REG_CM(3),
> > +#define PRTDCB_TCUPM_REG_DM(_i) (0x000BC3A0 +
> ((_i) * 4))
> > + PRTDCB_TCUPM_REG_DM(0),
> > + PRTDCB_TCUPM_REG_DM(1),
> > + PRTDCB_TCUPM_REG_DM(2),
> > + PRTDCB_TCUPM_REG_DM(3),
> > +#define PRTDCB_TLPM_REG_DM(_i) (0x000A0000 + ((_i) * 4))
> > + PRTDCB_TLPM_REG_DM(0),
> > + PRTDCB_TLPM_REG_DM(1),
> > + PRTDCB_TLPM_REG_DM(2),
> > + PRTDCB_TLPM_REG_DM(3),
> > };
> >
> > struct ice_priv_flag {
> >
> > base-commit: d0217284cea7d470e4140e98b806cb3cdf8257d6
> > --
> > 2.38.0.83.gd420dda05763
> >
Powered by blists - more mailing lists