netdev - RE: [PATCH] can: rcar_canfd: Add missing ECC error checks for channels 2-7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Oct 2022 11:27:45 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Marc Kleine-Budde <mkl@...gutronix.de>
CC:     Wolfgang Grandegger <wg@...ndegger.com>,
        Ulrich Hecht <uli+renesas@...nd.eu>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH] can: rcar_canfd: Add missing ECC error checks for
 channels 2-7

Hi Geert,

> Subject: Re: [PATCH] can: rcar_canfd: Add missing ECC error checks for
> channels 2-7
> 
> Hi Marc,
> 
> On Fri, Oct 28, 2022 at 12:29 PM Marc Kleine-Budde
> <mkl@...gutronix.de> wrote:
> > On 28.10.2022 12:06:45, Geert Uytterhoeven wrote:
> > > When introducing support for R-Car V3U, which has 8 instead of 2
> > > channels, the ECC error bitmask was extended to take into account
> > > the extra channels, but rcar_canfd_global_error() was not updated
> to
> > > act upon the extra bits.
> > >
> > > Replace the RCANFD_GERFL_EEF[01] macros by a new macro that takes
> > > the channel number, fixing R-Car V3U while simplifying the code.
> > >
> > > Fixes: 45721c406dcf50d4 ("can: rcar_canfd: Add support for
> r8a779a0
> > > SoC")
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> >
> > Is this stable material?
> 
> Upstream DTS[1] has only the first two channels enabled, so it's not
> critical. But it never hurts to end up in stable, helping e.g. CiP.

Yes, That will avoid backporting effort if it goes via stable.

FYI,  We have a plan to backport the whole CAN FD fixes/enhancement series to
5.10 cip [2] once it hits Linux mainline-rc.

[2] https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git/log/?h=linux-5.10.y-cip

Cheers,
Biju