lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y1v8CdFhpNSG8sHZ@lunn.ch> Date: Fri, 28 Oct 2022 17:58:01 +0200 From: Andrew Lunn <andrew@...n.ch> To: Fabio Estevam <festevam@...il.com> Cc: kuba@...nel.org, davem@...emloft.net, olteanv@...il.com, netdev@...r.kernel.org, Steffen Bätz <steffen@...osonix.de>, Fabio Estevam <festevam@...x.de> Subject: Re: [PATCH v2 net-next] net: dsa: mv88e6xxx: Add .port_set_rgmii_delay to 88E6320 On Fri, Oct 28, 2022 at 10:51:48AM -0300, Fabio Estevam wrote: > From: Steffen Bätz <steffen@...osonix.de> > > Currently, the port_set_rgmii_delay hook is missing for the 88E6320 > family, which causes failure to retrieve an IP address via DHCP. > > Add mv88e6320_port_set_rgmii_delay() that allows applying the RGMII > delay for ports 2, 5 and 6, which are the ports only that can be used > in RGMII mode. > > Tested on a i.MX8MN board connected to an 88E6320 switch. > > This change also applies safely to the 88E6321 variant. > @@ -5029,6 +5029,7 @@ static const struct mv88e6xxx_ops mv88e6320_ops = { > .phy_write = mv88e6xxx_g2_smi_phy_write, > .port_set_link = mv88e6xxx_port_set_link, > .port_sync_link = mv88e6xxx_port_sync_link, > + .port_set_rgmii_delay = mv88e6320_port_set_rgmii_delay, > .port_set_speed_duplex = mv88e6185_port_set_speed_duplex, > .port_tag_remap = mv88e6095_port_tag_remap, > .port_set_frame_mode = mv88e6351_port_set_frame_mode, You say it is safe, but then don't actually add it to mv88e6321_ops ? Andrew
Powered by blists - more mailing lists