netdev - Re: [PATCH net-next] net: microchip: sparx5: kunit test: change test_callbacks and test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Oct 2022 10:33:37 +0200
From:   Steen Hegelund <steen.hegelund@...rochip.com>
To:     Yang Yingliang <yangyingliang@...wei.com>, <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>
Subject: Re: [PATCH net-next] net: microchip: sparx5: kunit test: change
 test_callbacks and test_vctrl to static

Hi Yang,

On Fri, 2022-10-28 at 16:11 +0800, Yang Yingliang wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> test_callbacks and test_vctrl are only used in vcap_api_kunit.c now,
> change them to static.

Correct, they should have been static.
> 
> Fixes: 67d637516fa9 ("net: microchip: sparx5: Adding KUNIT test for the VCAP API")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/net/ethernet/microchip/vcap/vcap_api_kunit.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_kunit.c
> b/drivers/net/ethernet/microchip/vcap/vcap_api_kunit.c
> index b01a6e5039b0..d142ed660338 100644
> --- a/drivers/net/ethernet/microchip/vcap/vcap_api_kunit.c
> +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_kunit.c
> @@ -204,7 +204,7 @@ static int vcap_test_port_info(struct net_device *ndev, enum vcap_type vtype,
>         return 0;
>  }
> 
> -struct vcap_operations test_callbacks = {
> +static struct vcap_operations test_callbacks = {
>         .validate_keyset = test_val_keyset,
>         .add_default_fields = test_add_def_fields,
>         .cache_erase = test_cache_erase,
> @@ -216,7 +216,7 @@ struct vcap_operations test_callbacks = {
>         .port_info = vcap_test_port_info,
>  };
> 
> -struct vcap_control test_vctrl = {
> +static struct vcap_control test_vctrl = {
>         .vcaps = kunit_test_vcaps,
>         .stats = &kunit_test_vcap_stats,
>         .ops = &test_callbacks,
> --
> 2.25.1
> 
Thanks for providing this fix
BR
Steen

Reviewed-by: Steen Hegelund <Steen.Hegelund@...rochip.com>