| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Oct 2022 18:04:42 +0100
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
Andy Gross <agross@...nel.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Lars Povlsen <lars.povlsen@...rochip.com>,
Steen Hegelund <Steen.Hegelund@...rochip.com>,
Daniel Machon <daniel.machon@...rochip.com>,
UNGLinuxDriver@...rochip.com, Sergey Shtylyov <s.shtylyov@....ru>,
Manivannan Sadhasivam <mani@...nel.org>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Jonathan Marek <jonathan@...ek.ca>,
Martin Botka <martin.botka@...ainline.org>,
Taniya Das <tdas@...eaurora.org>,
Christian Marangi <ansuelsmth@...il.com>,
Stephan Gerhold <stephan@...hold.net>,
Shawn Guo <shawn.guo@...aro.org>,
Vinod Koul <vkoul@...nel.org>,
krishna Lanka <quic_vamslank@...cinc.com>,
Iskren Chernev <iskren.chernev@...il.com>,
Del Regno <angelogioacchino.delregno@...ainline.org>,
Robert Foss <robert.foss@...aro.org>,
Jeffrey Hugo <quic_jhugo@...cinc.com>,
Govind Singh <govinds@...eaurora.org>,
Loic Poulain <loic.poulain@...aro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Oleksij Rempel <linux@...pel-privat.de>,
Horatiu Vultur <horatiu.vultur@...rochip.com>,
Vladimir Oltean <vladimir.oltean@....com>,
Claudiu Manoil <claudiu.manoil@....com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: net: constrain number of 'reg' in ethernet
ports
On Fri, Oct 28, 2022 at 10:03:25AM -0400, Krzysztof Kozlowski wrote:
> 'reg' without any constraints allows multiple items which is not the
> intention for Ethernet controller's port number.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
For asix,ax88178.yaml and microchip,lan95xx.yaml
Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>
>
> ---
>
> Please give it a time for Rob's bot to process this.
> ---
> Documentation/devicetree/bindings/net/asix,ax88178.yaml | 4 +++-
> Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 4 +++-
> .../devicetree/bindings/net/microchip,lan966x-switch.yaml | 4 ++--
> .../devicetree/bindings/net/microchip,sparx5-switch.yaml | 3 ++-
> .../devicetree/bindings/net/mscc,vsc7514-switch.yaml | 3 ++-
> .../bindings/net/renesas,r8a779f0-ether-switch.yaml | 4 ++--
> 6 files changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/asix,ax88178.yaml b/Documentation/devicetree/bindings/net/asix,ax88178.yaml
> index 1af52358de4c..a81dbc4792f6 100644
> --- a/Documentation/devicetree/bindings/net/asix,ax88178.yaml
> +++ b/Documentation/devicetree/bindings/net/asix,ax88178.yaml
> @@ -27,7 +27,9 @@ properties:
> - usbb95,772b # ASIX AX88772B
> - usbb95,7e2b # ASIX AX88772B
>
> - reg: true
> + reg:
> + maxItems: 1
> +
> local-mac-address: true
> mac-address: true
>
> diff --git a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> index cf91fecd8909..3715c5f8f0e0 100644
> --- a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> +++ b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> @@ -39,7 +39,9 @@ properties:
> - usb424,9e08 # SMSC LAN89530 USB Ethernet Device
> - usb424,ec00 # SMSC9512/9514 USB Hub & Ethernet Device
>
> - reg: true
> + reg:
> + maxItems: 1
> +
> local-mac-address: true
> mac-address: true
>
> diff --git a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> index dc116f14750e..583d70c51be6 100644
> --- a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> @@ -83,8 +83,8 @@ properties:
> const: 0
>
> reg:
> - description:
> - Switch port number
> + items:
> + - description: Switch port number
>
> phys:
> description:
> diff --git a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> index 57ffeb8fc876..ccb912561446 100644
> --- a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> @@ -89,7 +89,8 @@ properties:
>
> properties:
> reg:
> - description: Switch port number
> + items:
> + - description: Switch port number
>
> phys:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> index ee0a504bdb24..1cf82955d75e 100644
> --- a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> @@ -109,7 +109,8 @@ properties:
>
> properties:
> reg:
> - description: Switch port number
> + items:
> + - description: Switch port number
>
> phy-handle: true
>
> diff --git a/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml b/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml
> index 581fff8902f4..0eba66a29c6c 100644
> --- a/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml
> @@ -106,8 +106,8 @@ properties:
>
> properties:
> reg:
> - description:
> - Port number of ETHA (TSNA).
> + items:
> + - description: Port number of ETHA (TSNA).
>
> phys:
> maxItems: 1
> --
> 2.34.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists