netdev - RE: [PATCH 2/2] thermal/drivers/mellanox: Use generic thermal_zone_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 30 Oct 2022 17:24:05 +0000
From:   Vadim Pasternak <vadimp@...dia.com>
To:     Ido Schimmel <idosch@...dia.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>
CC:     "rafael@...nel.org" <rafael@...nel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Petr Machata <petrm@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "open list:MELLANOX ETHERNET SWITCH DRIVERS" <netdev@...r.kernel.org>
Subject: RE: [PATCH 2/2] thermal/drivers/mellanox: Use generic
 thermal_zone_get_trip() function



> -----Original Message-----
> From: Ido Schimmel <idosch@...dia.com>
> Sent: Tuesday, 25 October 2022 13:32
> To: Daniel Lezcano <daniel.lezcano@...aro.org>; Vadim Pasternak
> <vadimp@...dia.com>
> Cc: Vadim Pasternak <vadimp@...dia.com>; rafael@...nel.org; linux-
> pm@...r.kernel.org; linux-kernel@...r.kernel.org; Petr Machata
> <petrm@...dia.com>; David S. Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>;
> Paolo Abeni <pabeni@...hat.com>; open list:MELLANOX ETHERNET SWITCH
> DRIVERS <netdev@...r.kernel.org>
> Subject: Re: [PATCH 2/2] thermal/drivers/mellanox: Use generic
> thermal_zone_get_trip() function
> 
> On Tue, Oct 25, 2022 at 09:02:23AM +0200, Daniel Lezcano wrote:
> > Because I hope I can remove the ops->get_trip_ ops from thermal_ops
> > structure before the end of this cycle.
> 
> OK. Vadim, any chance you can review the patch?

It seems to be OK.
Anyway, I'll take this patch for testing by the end of this week and update.

> 
> > May be you can consider moving the thermal driver into drivers/thermal?
> 
> I don't think it's worth the hassle (if possible at all). In practice, this code is
> upstream for almost six years and IIRC we didn't have any conflicts with the
> thermal tree. I don't expect conflicts this cycle either.