netdev - Re: [PATCH] net: mdio: fix undefined behavior in bit shift for __mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Oct 2022 13:35:17 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Gaosheng Cui <cuigaosheng1@...wei.com>
Cc:     hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        afleming@...escale.com, buytenh@...tstofly.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: mdio: fix undefined behavior in bit shift for
 __mdiobus_register

>  	for (i = 0; i < PHY_MAX_ADDR; i++) {
> -		if ((bus->phy_mask & (1 << i)) == 0) {
> +		if ((bus->phy_mask & (1U << i)) == 0) {

Please use the BIT() macro.

       Andrew