netdev - Re: [PATCH] net: mdio: fix undefined behavior in bit shift for __mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a456619-40de-44f1-f216-6ca338aadba3@huawei.com>
Date:   Mon, 31 Oct 2022 21:50:53 +0800
From:   cuigaosheng <cuigaosheng1@...wei.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     <hkallweit1@...il.com>, <linux@...linux.org.uk>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <afleming@...escale.com>,
        <buytenh@...tstofly.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: mdio: fix undefined behavior in bit shift for
 __mdiobus_register

> Please use the BIT() macro.

Thanks for taking time to review this patch, I have made patch v2 and submit it.

On 2022/10/31 20:35, Andrew Lunn wrote:
>>   	for (i = 0; i < PHY_MAX_ADDR; i++) {
>> -		if ((bus->phy_mask & (1 << i)) == 0) {
>> +		if ((bus->phy_mask & (1U << i)) == 0) {
> Please use the BIT() macro.
>
>         Andrew
> .