lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 Oct 2022 09:35:01 +0000 From: Lee Jones <lee@...nel.org> To: Colin Foster <colin.foster@...advantage.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, Russell King <linux@...linux.org.uk>, UNGLinuxDriver@...rochip.com, Alexandre Belloni <alexandre.belloni@...tlin.com>, Claudiu Manoil <claudiu.manoil@....com>, Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, Vladimir Oltean <olteanv@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Vivien Didelot <vivien.didelot@...il.com>, Andrew Lunn <andrew@...n.ch>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Rob Herring <robh+dt@...nel.org> Subject: Re: [RFC v4 net-next 12/17] mfd: ocelot: add shared resource names for switch functionality On Sat, 08 Oct 2022, Colin Foster wrote: > The switch portion of the Ocelot chip relies on several resources. Define > the resource names here, so they can be referenced by both the switch > driver and the MFD. > > Signed-off-by: Colin Foster <colin.foster@...advantage.com> > --- > > v4 > * New patch. Previous versions had entire structures shared, > this only requires that the names be shared. > > --- > include/linux/mfd/ocelot.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/linux/mfd/ocelot.h b/include/linux/mfd/ocelot.h > index dd72073d2d4f..b80f2f5ff1d6 100644 > --- a/include/linux/mfd/ocelot.h > +++ b/include/linux/mfd/ocelot.h > @@ -13,6 +13,15 @@ > > struct resource; > > +#define OCELOT_RES_NAME_ANA "ana" > +#define OCELOT_RES_NAME_QS "qs" > +#define OCELOT_RES_NAME_QSYS "qsys" > +#define OCELOT_RES_NAME_REW "rew" > +#define OCELOT_RES_NAME_SYS "sys" > +#define OCELOT_RES_NAME_S0 "s0" > +#define OCELOT_RES_NAME_S1 "s1" > +#define OCELOT_RES_NAME_S2 "s2" I've never been a fan of defining name strings. The end of the define name is identical to the resource names. This also makes grepping that much harder for little gain. -- Lee Jones [李琼斯]
Powered by blists - more mailing lists