netdev - Re: [PATCH net-next v2 2/2] rocker: Explicitly mark learned FDB entries as offloaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221101162134.c3kxls7tvz2csctm@skbuf>
Date:   Tue, 1 Nov 2022 16:21:34 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Ido Schimmel <idosch@...dia.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "netdev@...io-technology.com" <netdev@...io-technology.com>,
        "mlxsw@...dia.com" <mlxsw@...dia.com>
Subject: Re: [PATCH net-next v2 2/2] rocker: Explicitly mark learned FDB
 entries as offloaded

On Tue, Nov 01, 2022 at 02:39:36PM +0200, Ido Schimmel wrote:
> Currently, FDB entries that are notified to the bridge driver via
> 'SWITCHDEV_FDB_ADD_TO_BRIDGE' are always marked as offloaded by the
> bridge. With MAB enabled, this will no longer be universally true.
> Device drivers will report locked FDB entries to the bridge to let it
> know that the corresponding hosts required authorization, but it does
> not mean that these entries are necessarily programmed in the underlying
> hardware.
> 
> We would like to solve it by having the bridge driver determine the
> offload indication based of the 'offloaded' bit in the FDB notification
> [1].
> 
> Prepare for that change by having rocker explicitly mark learned FDB
> entries as offloaded. This is consistent with all the other switchdev
> drivers.
> 
> [1] https://lore.kernel.org/netdev/20221025100024.1287157-4-idosch@nvidia.com/
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>