netdev - Re: [PATCH net-next v2 1/2] rocker: Avoid unnecessary scheduling of work item

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221101162106.xaikqelommua5xib@skbuf>
Date:   Tue, 1 Nov 2022 16:21:07 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Ido Schimmel <idosch@...dia.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "netdev@...io-technology.com" <netdev@...io-technology.com>,
        "mlxsw@...dia.com" <mlxsw@...dia.com>
Subject: Re: [PATCH net-next v2 1/2] rocker: Avoid unnecessary scheduling of
 work item

On Tue, Nov 01, 2022 at 02:39:35PM +0200, Ido Schimmel wrote:
> The work item function ofdpa_port_fdb_learn_work() does not do anything
> when 'OFDPA_OP_FLAG_LEARNED' is not set in the work item's flags.
> 
> Therefore, do not allocate and do not schedule the work item when the
> flag is not set.
> 
> Suggested-by: Vladimir Oltean <vladimir.oltean@....com>
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>