netdev - Re: [PATCH net-next v3] ethtool: linkstate: add a statistic for PHY down events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLikHJphFqB=NBZ3zQPNW=9PY9SX2evs6sfHD7GJrA7ey=g@mail.gmail.com>
Date:   Mon, 31 Oct 2022 23:08:39 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, Florian Fainelli <f.fainelli@...il.com>,
        corbet@....net, andrew@...n.ch, hkallweit1@...il.com,
        linux@...linux.org.uk, huangguangbin2@...wei.com,
        chenhao288@...ilicon.com, moshet@...dia.com,
        linux@...pel-privat.de, linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next v3] ethtool: linkstate: add a statistic for PHY
 down events

On Mon, Oct 31, 2022 at 10:26 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> The previous attempt to augment carrier_down (see Link)
> was not met with much enthusiasm so let's do the simple
> thing of exposing what some devices already maintain.
> Add a common ethtool statistic for link going down.
> Currently users have to maintain per-driver mapping
> to extract the right stat from the vendor-specific ethtool -S
> stats. carrier_down does not fit the bill because it counts
> a lot of software related false positives.
>
> Add the statistic to the extended link state API to steer
> vendors towards implementing all of it.
>
> Implement for bnxt and all Linux-controlled PHYs. mlx5 and (possibly)
> enic also have a counter for this but I leave the implementation
> to their maintainers.
>
> Link: https://lore.kernel.org/r/20220520004500.2250674-1-kuba@kernel.org
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> --
> v3:
>  - make the stat u32 (apart from the ethtool struct which uses u64s
>    for the "not set" detection, whatevs)
> v2:
>  - add phylib support

Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)