lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8c501b46825a4579a88ff16f53e9bcc4@realtek.com> Date: Tue, 1 Nov 2022 06:41:00 +0000 From: Ping-Ke Shih <pkshih@...ltek.com> To: Colin Ian King <colin.i.king@...il.com>, Kalle Valo <kvalo@...nel.org>, "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> CC: "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt > -----Original Message----- > From: Ping-Ke Shih > Sent: Tuesday, November 1, 2022 8:22 AM > To: 'Colin Ian King' <colin.i.king@...il.com>; Kalle Valo <kvalo@...nel.org>; David S . Miller > <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni > <pabeni@...hat.com>; linux-wireless@...r.kernel.org; netdev@...r.kernel.org > Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org > Subject: RE: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt > > > > -----Original Message----- > > From: Colin Ian King <colin.i.king@...il.com> > > Sent: Monday, October 31, 2022 11:57 PM > > To: Ping-Ke Shih <pkshih@...ltek.com>; Kalle Valo <kvalo@...nel.org>; David S . Miller > > <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni > > <pabeni@...hat.com>; linux-wireless@...r.kernel.org; netdev@...r.kernel.org > > Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org > > Subject: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt Subject prefix should be "wifi: rtlwifi: ..." I'm not sure if Kalle can help this, or you can send v2 to add prefix. > > > > Variable stop_report_cnt is being set or incremented but is never > > being used for anything meaningful. The variable and code relating > > to it's use is redundant and can be removed. > > > > Signed-off-by: Colin Ian King <colin.i.king@...il.com> > > Acked-by: Ping-Ke Shih <pkshih@...ltek.com> > > > --- > > drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 8 -------- > > 1 file changed, 8 deletions(-) > > > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c > > b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c > > index 8043d819fb85..a182cdeb58e2 100644 > > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c > > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c > > @@ -997,7 +997,6 @@ bool rtl92ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index) > > struct rtl_priv *rtlpriv = rtl_priv(hw); > > u16 read_point, write_point; > > bool ret = false; > > - static u8 stop_report_cnt; > > struct rtl8192_tx_ring *ring = &rtlpci->tx_ring[hw_queue]; > > > > { > > @@ -1038,13 +1037,6 @@ bool rtl92ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index) > > rtlpriv->psc.rfoff_reason > RF_CHANGE_BY_PS) > > ret = true; > > > > - if (hw_queue < BEACON_QUEUE) { > > - if (!ret) > > - stop_report_cnt++; > > - else > > - stop_report_cnt = 0; > > - } > > - > > return ret; > > } > > > > -- > > 2.37.3 > > > > > > ------Please consider the environment before printing this e-mail.
Powered by blists - more mailing lists