netdev - Re: [PATCH ethtool] fsl_enetc: add support for NXP ENETC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221103222014.6hi4sxn53j5s4cw2@skbuf>
Date:   Thu, 3 Nov 2022 22:20:15 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Michal Kubecek <mkubecek@...e.cz>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Claudiu Manoil <claudiu.manoil@....com>
Subject: Re: [PATCH ethtool] fsl_enetc: add support for NXP ENETC driver

Hi Michal,

On Tue, Nov 01, 2022 at 05:34:53PM +0100, Michal Kubecek wrote:
> > +#define BIT(x)			(1 << (x))
> 
> This macro is only used to mask bits of a u32 value, wouldn't "1U" be
> more appropriate?

I'm not sure that signed vs unsigned operands make a difference for left
shifting (as opposed to right shifting where they definitely do), but I
will make this change and resubmit. Thanks for the review.