netdev - Re: [PATCH -next v2] net: ethernet: Simplify bool conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y2UyqcjbDYx1rqcd@lunn.ch>
Date:   Fri, 4 Nov 2022 16:41:29 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     bagasdotme@...il.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, richardcochran@...il.com,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next v2] net: ethernet: Simplify bool conversion

On Fri, Nov 04, 2022 at 11:03:13AM +0800, Yang Li wrote:
> The result of 'scaled_ppm < 0' is Boolean, and the question mark
> expression is redundant, remove it to clear the below warning:
> 
> ./drivers/net/ethernet/renesas/rcar_gen4_ptp.c:32:40-45: WARNING: conversion to bool not needed here
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2729
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
> 
> change in v2:
> --According to Bagas's suggestion, describe what this patch does to fix this warning. 

The Subject line is too generic. It is a good idea to run git log on
the file you are changing and see how it is generally referred to:

b48b89f9c189 net: drop the weight argument from netif_napi_add
0140a7168f8b Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
6a1dbfefdae4 net: sh_eth: Fix PHY state warning splat during system resume
4924c0cdce75 net: ravb: Fix PHY state warning splat during system resume
1089877ada8d ravb: Add RZ/G2L MII interface support
949f252a8594 net: ravb: Add R-Car Gen4 support
e1154be73153 ravb: Add support for RZ/V2M
72069a7b2821 ravb: Use separate clock for gPTP
b0265dcba3d6 ravb: Support separate Line0 (Desc), Line1 (Err) and Line2 (Mgmt) irqs
cb99badde146 ravb: Separate handling of irq enable/disable regs into feature
91398a960edf ravb: Use GFP_KERNEL instead of GFP_ATOMIC when possible
9a90986efcff sh_eth: kill useless initializers in sh_eth_{suspend|resume}()
e7d966f9ea52 sh_eth: sh_eth_close() always returns 0
be94a51f3e5e ravb: ravb_close() always returns 0

Without something specific like ravb, you won't get the right people
noticing the patch.

	 Andrew