netdev - Re: [PATCH -next v2] net: ethernet: Simplify bool conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2SubudMxMLV8R8D@hoboy.vegasvil.org>
Date:   Thu, 3 Nov 2022 23:17:18 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     bagasdotme@...il.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next v2] net: ethernet: Simplify bool conversion

On Fri, Nov 04, 2022 at 11:03:13AM +0800, Yang Li wrote:

> diff --git a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
> index c007e33c47e1..37f7359678e5 100644
> --- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
> +++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
> @@ -29,7 +29,7 @@ static const struct rcar_gen4_ptp_reg_offset s4_offs = {
>  static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm)
>  {
>  	struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp);
> -	bool neg_adj = scaled_ppm < 0 ? true : false;
> +	bool neg_adj = scaled_ppm < 0;
>  	s64 addend = ptp_priv->default_addend;
>  	s64 diff;

Please preserve reverse Christmas tree order.

Thanks,
Richard