netdev - Re: [PATCH v3] wifi: rsi: Fix handling of 802.3 EAPOL frames sent via control port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf7da8e9a135fee1a9ac0e8f768a2a13bbba058d.camel@sipsolutions.net>
Date:   Fri, 04 Nov 2022 17:01:32 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Marek Vasut <marex@...x.de>, linux-wireless@...r.kernel.org
Cc:     Amitkumar Karwar <amit.karwar@...pinesignals.com>,
        Angus Ainslie <angus@...ea.ca>,
        Jakub Kicinski <kuba@...nel.org>,
        Kalle Valo <kvalo@...nel.org>,
        Martin Fuzzey <martin.fuzzey@...wbird.group>,
        Martin Kepplinger <martink@...teo.de>,
        Prameela Rani Garnepudi <prameela.j04cs@...il.com>,
        Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>,
        Siva Rebbagondla <siva8118@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v3] wifi: rsi: Fix handling of 802.3 EAPOL frames sent
 via control port

On Fri, 2022-11-04 at 16:58 +0100, Marek Vasut wrote:
> 
> Therefore, to fix this problem, inspect the ETH_P_802_3 frames in
> the rsi_91x driver, check the ethertype of the encapsulated frame,
> and in case it is ETH_P_PAE, transmit the frame via high-priority
> queue just like other ETH_P_PAE frames.

This part seems wrong now.

> +bool rsi_is_tx_eapol(struct sk_buff *skb)
> +{
> +	return !!(IEEE80211_SKB_CB(skb)->control.flags &
> +		  IEEE80211_TX_CTRL_PORT_CTRL_PROTO);
> +}

For how trivial this is now, maybe make it an inline? Feels fairly
pointless to have it as an out-of-line function to call in another file
when it's a simple bit check.

You can also drop the !! since the return value is bool.

johannes