netdev - Re: [PATCH v3] wifi: rsi: Fix handling of 802.3 EAPOL frames sent via control port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3ef782d-9c85-d752-52b5-589d5e1f1bd5@denx.de>
Date:   Fri, 4 Nov 2022 17:09:48 +0100
From:   Marek Vasut <marex@...x.de>
To:     Johannes Berg <johannes@...solutions.net>,
        linux-wireless@...r.kernel.org
Cc:     Amitkumar Karwar <amit.karwar@...pinesignals.com>,
        Angus Ainslie <angus@...ea.ca>,
        Jakub Kicinski <kuba@...nel.org>,
        Kalle Valo <kvalo@...nel.org>,
        Martin Fuzzey <martin.fuzzey@...wbird.group>,
        Martin Kepplinger <martink@...teo.de>,
        Prameela Rani Garnepudi <prameela.j04cs@...il.com>,
        Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>,
        Siva Rebbagondla <siva8118@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v3] wifi: rsi: Fix handling of 802.3 EAPOL frames sent via
 control port

On 11/4/22 17:01, Johannes Berg wrote:
> On Fri, 2022-11-04 at 16:58 +0100, Marek Vasut wrote:
>>
>> Therefore, to fix this problem, inspect the ETH_P_802_3 frames in
>> the rsi_91x driver, check the ethertype of the encapsulated frame,
>> and in case it is ETH_P_PAE, transmit the frame via high-priority
>> queue just like other ETH_P_PAE frames.
> 
> This part seems wrong now.

OK

>> +bool rsi_is_tx_eapol(struct sk_buff *skb)
>> +{
>> +	return !!(IEEE80211_SKB_CB(skb)->control.flags &
>> +		  IEEE80211_TX_CTRL_PORT_CTRL_PROTO);
>> +}
> 
> For how trivial this is now, maybe make it an inline? Feels fairly
> pointless to have it as an out-of-line function to call in another file
> when it's a simple bit check.

In V2 it was suggested I deduplicate this into a separate function, 
since the test is done in multiple places. I would like to keep it 
deduplicated.

> You can also drop the !! since the return value is bool.

OK