netdev - Re: [PATCH v3] wifi: rsi: Fix handling of 802.3 EAPOL frames sent via control port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f3b0adccfff86b687bf2e9fd3e3f9657444bfdf0.camel@sipsolutions.net>
Date:   Fri, 04 Nov 2022 17:25:09 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Marek Vasut <marex@...x.de>, linux-wireless@...r.kernel.org
Cc:     Angus Ainslie <angus@...ea.ca>, Jakub Kicinski <kuba@...nel.org>,
        Kalle Valo <kvalo@...nel.org>,
        Martin Fuzzey <martin.fuzzey@...wbird.group>,
        Martin Kepplinger <martink@...teo.de>,
        Prameela Rani Garnepudi <prameela.j04cs@...il.com>,
        Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>,
        Siva Rebbagondla <siva8118@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v3] wifi: rsi: Fix handling of 802.3 EAPOL frames sent
 via control port

(removing Amitkumar Karwar <amit.karwar@...pinesignals.com> as that
keeps bouncing)

On Fri, 2022-11-04 at 17:23 +0100, Johannes Berg wrote:
> On Fri, 2022-11-04 at 17:09 +0100, Marek Vasut wrote:
> > 
> > In V2 it was suggested I deduplicate this into a separate function, 
> > since the test is done in multiple places. I would like to keep it 
> > deduplicated.
> 
> Well, it's now a lot simpler, so one might argue that it's not needed.
> 
> But anyway you're touching the hot-path of this driver, and making it an
> inline still keeps it de-duplicated, so not sure why you wouldn't just
> move the rsi_is_tx_eapol into the header file as static inline?
> 

Though honestly, if we thought it was worth deduplicating a simple bit
check like that, we could define an inline helper in mac80211.h. I'm not
really convinced it is :)

But hey, that's not my driver, so ultimately I don't _really_ care so
much.

johannes