netdev - Re: [PATCH net 4/5] can: dev: fix skb drop check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7389601-40aa-2372-b185-387bd20fe701@hartkopp.net>
Date:   Sat, 5 Nov 2022 10:01:15 +0100
From:   Oliver Hartkopp <socketcan@...tkopp.net>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Marc Kleine-Budde <mkl@...gutronix.de>, netdev@...r.kernel.org,
        davem@...emloft.net, linux-can@...r.kernel.org,
        kernel@...gutronix.de,
        Dariusz Stojaczyk <Dariusz.Stojaczyk@...nsynergy.com>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        Max Staudt <max@...as.org>, stable@...r.kernel.org
Subject: Re: [PATCH net 4/5] can: dev: fix skb drop check



On 04.11.22 23:36, Jakub Kicinski wrote:
> On Fri, 4 Nov 2022 21:33:16 +0100 Oliver Hartkopp wrote:
>> On 04.11.22 19:50, Jakub Kicinski wrote:
>>> On Fri,  4 Nov 2022 14:05:34 +0100 Marc Kleine-Budde wrote:
>>>> -	if (can_dropped_invalid_skb(ndev, skb))
>>>> +	if (can_dev_dropped_skb(dev, skb))
>>>
>>> Compiler says "Did you mean ndev"?
>>
>> Your compiler is a smart buddy! Sorry!
>>
>> Marc added that single change to my patch for the pch_can.c driver
>> (which is removed in net-next but not in 6.1-rc).
>>
>> And in pch_can.c the netdev is named ndev.
>>
>> Would you like to fix this up on your own or should we send an updated
>> PR for the series?
> 
> Updated PR would be better, if possible.
> We don't edit patches locally much (at all?) when applying to netdev.

Ok, thanks!

I have posted another patch which could be added to the updated PR too then.

https://lore.kernel.org/linux-can/20221104142551.16924-1-socketcan@hartkopp.net/T/#u

Best regards,
Oliver