netdev - Re: NET_RX_DROP question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db2af4c2d70fb2582fbf5e27a31052d9d9c57953.camel@infinera.com>
Date:   Mon, 7 Nov 2022 14:54:28 +0000
From:   Joakim Tjernlund <Joakim.Tjernlund@...inera.com>
To:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: NET_RX_DROP question

On Thu, 2022-11-03 at 15:08 +0100, Joakim Tjernlund wrote:
> In our ethernet drivers RX path we have:
>   if (netif_receive_skb(skb) == NET_RX_DROP)
>      priv->stats.rx_dropped++;
> 
> Now we can see dropped counter counting dropped pkgs but we don't see
> any corrupt pkgs etc. Is NET_RX_DROP really meant to be used like this?
> It gives the impression that there is something wrong with the driver.
> 
>  Jocke

Looking into drivers/net/ethernet is seems just a few checks if (netif_receive_skb(skb) == NET_RX_DROP),
the majority does not which makes me this I should just drop this check.

Confirmation more than welcome.

 Jocke