netdev - Re: NET_RX_DROP question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 7 Nov 2022 17:48:37 +0100
From:   Francois Romieu <romieu@...zoreil.com>
To:     Joakim Tjernlund <Joakim.Tjernlund@...inera.com>
Cc:     netdev@...r.kernel.org
Subject: Re: NET_RX_DROP question

Joakim Tjernlund <Joakim.Tjernlund@...inera.com> :
[...]
> Looking into drivers/net/ethernet is seems just a few checks if (netif_receive_skb(skb) == NET_RX_DROP),
> the majority does not which makes me this I should just drop this check.
> 
> Confirmation more than welcome.

The driver should not maintain stats for packets dropped by
the core network. They are already accounted for in core stats
(include/linux/netdevice.c::struct net_device.core_stats).

-- 
Ueimor