netdev - Re: [PATCH net-next 1/3] bnxt_en: refactor VNIC RSS update functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2i4+vudfY71/yn3@unreal>
Date:   Mon, 7 Nov 2022 09:51:22 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, kuba@...nel.org,
        edumazet@...gle.com, pabeni@...hat.com, gospo@...adcom.com,
        pavan.chebbi@...adcom.com
Subject: Re: [PATCH net-next 1/3] bnxt_en: refactor VNIC RSS update functions

On Sun, Nov 06, 2022 at 07:16:30PM -0500, Michael Chan wrote:
> From: Edwin Peer <edwin.peer@...adcom.com>
> 
> Extract common code into a new function. This will avoid duplication
> in the next patch, which changes the update algorithm for both the P5
> and legacy code paths.
> 
> No functional changes.
> 
> Signed-off-by: Edwin Peer <edwin.peer@...adcom.com>
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 34 +++++++++++------------
>  1 file changed, 16 insertions(+), 18 deletions(-)

<...>

> +static void
> +__bnxt_hwrm_vnic_set_rss(struct bnxt *bp, struct hwrm_vnic_rss_cfg_input *req,
> +			 struct bnxt_vnic_info *vnic)

The "__" prefix in __func_name() usually means in kernel that this function
is locked externally.

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>