netdev - Re: [PATCH net-next 2/3] bnxt_en: update RSS config using difference algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Nov 2022 09:51:41 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, kuba@...nel.org,
        edumazet@...gle.com, pabeni@...hat.com, gospo@...adcom.com,
        pavan.chebbi@...adcom.com
Subject: Re: [PATCH net-next 2/3] bnxt_en: update RSS config using difference
 algorithm

On Sun, Nov 06, 2022 at 07:16:31PM -0500, Michael Chan wrote:
> From: Edwin Peer <edwin.peer@...adcom.com>
> 
> Hardware is unable to realize all legal firmware interface state values
> for hash_type.  For example, if 4-tuple TCP_IPV4 hash is enabled,
> 4-tuple UDP_IPV4 hash must also be enabled.  By providing the bits the
> user intended to change instead of the possible illegal intermediate
> states, the firmware is able to make better compromises when deciding
> which bits to ignore.
> 
> With this new mechansim, we can now report the actual configured hash
> back to the user.  Add bnxt_hwrm_update_rss_hash_cfg() to report the
> actual hash after user configuration.
> 
> Signed-off-by: Edwin Peer <edwin.peer@...adcom.com>
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 35 +++++++++++++-
>  drivers/net/ethernet/broadcom/bnxt/bnxt.h     |  2 +
>  .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  2 +
>  drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 47 +++++++++++++++++++
>  4 files changed, 85 insertions(+), 1 deletion(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>