netdev - Re: [patch iproute2-next 1/3] devlink: query ifname for devlink port instead of map lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Nov 2022 08:59:23 -0700
From:   David Ahern <dsahern@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, moshe@...dia.com
Subject: Re: [patch iproute2-next 1/3] devlink: query ifname for devlink port
 instead of map lookup

On 11/7/22 8:54 AM, Jiri Pirko wrote:
> Mon, Nov 07, 2022 at 04:16:42PM CET, dsahern@...il.com wrote:
>> On 11/4/22 4:23 AM, Jiri Pirko wrote:
>>> From: Jiri Pirko <jiri@...dia.com>
>>>
>>> ifname map is created once during init. However, ifnames can easily
>>> change during the devlink process runtime (e. g. devlink mon).
>>
>> why not update the cache on name changes? Doing a query on print has
> 
> We would have to listen on RTNetlink for the changes, as devlink does
> not send such events on netdev ifname change.
> 
> 
>> extra overhead. And, if you insist a per-print query is needed, why
>> leave ifname_map_list? what value does it serve if you query each time?
> 
> Correct.

"Correct" is not a response to a series of questions.

You followed up that 1 word response with a 2 patch set that has the
same title as patch 3 in this set. Please elaborate.