netdev - Re: [patch iproute2-next 1/3] devlink: query ifname for devlink port instead of map lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y2uVszm5PTRGeW2E@nanopsycho>
Date:   Wed, 9 Nov 2022 12:57:39 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, moshe@...dia.com
Subject: Re: [patch iproute2-next 1/3] devlink: query ifname for devlink port
 instead of map lookup

Tue, Nov 08, 2022 at 04:59:23PM CET, dsahern@...il.com wrote:
>On 11/7/22 8:54 AM, Jiri Pirko wrote:
>> Mon, Nov 07, 2022 at 04:16:42PM CET, dsahern@...il.com wrote:
>>> On 11/4/22 4:23 AM, Jiri Pirko wrote:
>>>> From: Jiri Pirko <jiri@...dia.com>
>>>>
>>>> ifname map is created once during init. However, ifnames can easily
>>>> change during the devlink process runtime (e. g. devlink mon).
>>>
>>> why not update the cache on name changes? Doing a query on print has
>> 
>> We would have to listen on RTNetlink for the changes, as devlink does
>> not send such events on netdev ifname change.
>> 
>> 
>>> extra overhead. And, if you insist a per-print query is needed, why
>>> leave ifname_map_list? what value does it serve if you query each time?
>> 
>> Correct.
>
>"Correct" is not a response to a series of questions.
>
>You followed up that 1 word response with a 2 patch set that has the
>same title as patch 3 in this set. Please elaborate.

Sorry. You are correct, per-print query makes the map needless. That is
what I ment. I'm redoing this, tracking the changes coming from the
kernel (port ifname change actually gets propagated).

I sent v2 without this patch included, that means it contains only patch
3 with the dependency patch. That is why the patchset has the same name
as patch 3.

I'm working on the tracking patchset to replace this patch. Hope this
cleared your concerns.

Thanks!