netdev - Re: [PATCH net-next v2 4/4] mlxbf_gige: add "set_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2z78lwaeJKnL6DJ@lunn.ch>
Date:   Thu, 10 Nov 2022 14:26:10 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     David Thompson <davthompson@...dia.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org, cai.huoqing@...ux.dev,
        brgl@...ev.pl, limings@...dia.com, chenhao288@...ilicon.com,
        huangguangbin2@...wei.com, Asmaa Mnebhi <asmaa@...dia.com>
Subject: Re: [PATCH net-next v2 4/4] mlxbf_gige: add "set_link_ksettings"
 ethtool callback

On Wed, Nov 09, 2022 at 05:47:52PM -0500, David Thompson wrote:
> This patch extends the "ethtool_ops" data structure to
> include the "set_link_ksettings" callback. This change
> enables configuration of the various interface speeds
> that the BlueField-3 supports (10Mbps, 100Mbps, and 1Gbps).
> 
> Signed-off-by: David Thompson <davthompson@...dia.com>
> Signed-off-by: Asmaa Mnebhi <asmaa@...dia.com>
> ---
>  drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_ethtool.c | 1 +
>  drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c    | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_ethtool.c b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_ethtool.c
> index 41ebef25a930..253d7ad9b809 100644
> --- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_ethtool.c
> +++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_ethtool.c
> @@ -135,4 +135,5 @@ const struct ethtool_ops mlxbf_gige_ethtool_ops = {
>  	.nway_reset		= phy_ethtool_nway_reset,
>  	.get_pauseparam		= mlxbf_gige_get_pauseparam,
>  	.get_link_ksettings	= phy_ethtool_get_link_ksettings,
> +	.set_link_ksettings	= phy_ethtool_set_link_ksettings,
>  };
> diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
> index 80060a54ba95..a9fa662e0665 100644
> --- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
> +++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
> @@ -224,7 +224,7 @@ static int mlxbf_gige_stop(struct net_device *netdev)
>  }
>  
>  static int mlxbf_gige_eth_ioctl(struct net_device *netdev,
> -			       struct ifreq *ifr, int cmd)
> +				struct ifreq *ifr, int cmd)
>  {
>  	if (!(netif_running(netdev)))
>  		return -EINVAL;

White space changes should be in a separate patch.

With this fixed:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew