netdev - Re: [PATCH net-next v2 3/4] mlxbf_gige: add BlueField-3 Serdes configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2z9u4qCsLmx507g@lunn.ch>
Date:   Thu, 10 Nov 2022 14:33:47 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     David Thompson <davthompson@...dia.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org, cai.huoqing@...ux.dev,
        brgl@...ev.pl, limings@...dia.com, chenhao288@...ilicon.com,
        huangguangbin2@...wei.com, Asmaa Mnebhi <asmaa@...dia.com>
Subject: Re: [PATCH net-next v2 3/4] mlxbf_gige: add BlueField-3 Serdes
 configuration

On Wed, Nov 09, 2022 at 05:47:51PM -0500, David Thompson wrote:
> The BlueField-3 out-of-band Ethernet interface requires
> SerDes configuration. There are two aspects to this:
> 
> Configuration of PLL:
>     1) Initialize UPHY registers to values dependent on p1clk clock
>     2) Load PLL best known values via the gateway register
>     3) Set the fuses to tune up the SerDes voltage
>     4) Lock the PLL
>     5) Get the lanes out of functional reset.
>     6) Configure the UPHY microcontroller via gateway reads/writes
> 
> Configuration of lanes:
>     1) Configure and open TX lanes
>     2) Configure and open RX lanes

I still don't like all these black magic tables in the driver.

But lets see what others say.

    Andrew