netdev - Re: [PATCH 2/2] net: sky2: Fix error handling in sky2_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202211131840.Fulm73J6-lkp@intel.com>
Date:   Sun, 13 Nov 2022 19:09:40 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yuan Can <yuancan@...wei.com>, mlindner@...vell.com,
        stephen@...workplumber.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        jeff@...zik.org, netdev@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, yuancan@...wei.com
Subject: Re: [PATCH 2/2] net: sky2: Fix error handling in sky2_init_module()

Hi Yuan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on net/master linus/master v6.1-rc4 next-20221111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yuan-Can/Fix-error-handling-path/20221113-174019
patch link:    https://lore.kernel.org/r/20221113093719.23687-3-yuancan%40huawei.com
patch subject: [PATCH 2/2] net: sky2: Fix error handling in sky2_init_module()
config: i386-defconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/ec8673a78a9b9fd5452193e20a75ed983b6cf668
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Yuan-Can/Fix-error-handling-path/20221113-174019
        git checkout ec8673a78a9b9fd5452193e20a75ed983b6cf668
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/marvell/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/marvell/sky2.c: In function 'sky2_init_module':
>> drivers/net/ethernet/marvell/sky2.c:5154:37: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
    5154 |                 sky2_debug_cleanup();
         |                                     ^


vim +/if +5154 drivers/net/ethernet/marvell/sky2.c

  5144	
  5145	static int __init sky2_init_module(void)
  5146	{
  5147		int ret;
  5148	
  5149		pr_info("driver version " DRV_VERSION "\n");
  5150	
  5151		sky2_debug_init();
  5152		ret = pci_register_driver(&sky2_driver);
  5153		if (ret)
> 5154			sky2_debug_cleanup();
  5155	
  5156		return ret;
  5157	}
  5158	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (134580 bytes)