netdev - Re: [PATCH 1/2] net: skge: Fix error handling in skge_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202211132126.OBsdb2S2-lkp@intel.com>
Date:   Sun, 13 Nov 2022 21:41:06 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yuan Can <yuancan@...wei.com>, mlindner@...vell.com,
        stephen@...workplumber.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        jeff@...zik.org, netdev@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, yuancan@...wei.com
Subject: Re: [PATCH 1/2] net: skge: Fix error handling in skge_init_module()

Hi Yuan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on net/master linus/master v6.1-rc4 next-20221111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yuan-Can/Fix-error-handling-path/20221113-174019
patch link:    https://lore.kernel.org/r/20221113093719.23687-2-yuancan%40huawei.com
patch subject: [PATCH 1/2] net: skge: Fix error handling in skge_init_module()
config: openrisc-buildonly-randconfig-r003-20221113
compiler: or1k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/d0e0ff74baf3e1336c052f8100f16f21b80b43a6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Yuan-Can/Fix-error-handling-path/20221113-174019
        git checkout d0e0ff74baf3e1336c052f8100f16f21b80b43a6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/net/ethernet/marvell/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/marvell/skge.c: In function 'skge_init_module':
>> drivers/net/ethernet/marvell/skge.c:4189:37: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
    4189 |                 skge_debug_cleanup();
         |                                     ^


vim +/if +4189 drivers/net/ethernet/marvell/skge.c

  4179	
  4180	static int __init skge_init_module(void)
  4181	{
  4182		int ret;
  4183	
  4184		if (dmi_check_system(skge_32bit_dma_boards))
  4185			only_32bit_dma = 1;
  4186		skge_debug_init();
  4187		ret = pci_register_driver(&skge_driver);
  4188		if (ret)
> 4189			skge_debug_cleanup();
  4190	
  4191		return ret;
  4192	}
  4193	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (175023 bytes)