netdev - Re: [PATCH (repost) net-next] sched: add extack for tfilter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMmS3rStT3GozeV2-n+MYS8QqeZb9q5QQcifc9EbaQWR3w@mail.gmail.com>
Date:   Tue, 15 Nov 2022 07:42:13 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Hangbin Liu <liuhangbin@...il.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH (repost) net-next] sched: add extack for tfilter_notify

On Mon, Nov 14, 2022 at 11:51 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 15 Nov 2022 11:07:21 +0800 Hangbin Liu wrote:

[..]
> > I have finished a patch with TCA_NTF_WARN_MSG to carry the string message.
> > But looks our discussion goes to a way that this feature is not valuable?
> >
> > So maybe I should stop on here?
>
> It's a bit of a catch 22 - I don't mind the TCA_NTF_WARN_MSG itself
> but I would prefer for the extack via notification to spread to other
> notifications.
>

+1.
I got distracted but was thinking of  sending a sample patch. I think
we can do it for all if we pass extack to nlmsg_notify() from all callers
and then check if extack is present and do the NLM_F_ACK_TLVS
dance in there.
Hangbin - maybe consider this approach?

cheers,
jamal

> If you have the code ready - post it, let's see how folks feel after
> sleeping on it.