netdev - Re: [PATCH v2] netfilter: ctmark: Fix data-races around ctmark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 18 Nov 2022 11:29:25 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Daniel Xu <dxu@...uu.xyz>
Cc:     fw@...len.de, kadlec@...filter.org,
        netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] netfilter: ctmark: Fix data-races around ctmark

On Wed, Nov 09, 2022 at 12:39:07PM -0700, Daniel Xu wrote:
> nf_conn:mark can be read from and written to in parallel. Use
> READ_ONCE()/WRITE_ONCE() for reads and writes to prevent unwanted
> compiler optimizations.
> 
> Signed-off-by: Daniel Xu <dxu@...uu.xyz>
> ---
> Changes since v1:
> - Remove WRITE_ONCE() from init path
> 
>  net/core/flow_dissector.c               |  2 +-
>  net/ipv4/netfilter/ipt_CLUSTERIP.c      |  4 ++--
>  net/netfilter/nf_conntrack_core.c       |  2 +-
>  net/netfilter/nf_conntrack_netlink.c    | 24 ++++++++++++++----------
>  net/netfilter/nf_conntrack_standalone.c |  2 +-
>  net/netfilter/nft_ct.c                  |  6 +++---
>  net/netfilter/xt_connmark.c             | 18 ++++++++++--------
>  net/openvswitch/conntrack.c             |  8 ++++----
>  net/sched/act_connmark.c                |  4 ++--
>  net/sched/act_ct.c                      |  8 ++++----
>  net/sched/act_ctinfo.c                  |  6 +++---
>  11 files changed, 45 insertions(+), 39 deletions(-)

I am going to place this in nf.git, it's a bit late but it's
relatively small and I think the sooner the better to have this fix.