lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 20 Nov 2022 10:54:11 +0100 From: netdev@...io-technology.com To: Vladimir Oltean <olteanv@...il.com> Cc: davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v8 net-next 2/2] net: dsa: mv88e6xxx: mac-auth/MAB implementation On 2022-11-15 23:23, Vladimir Oltean wrote: > On Sat, Nov 12, 2022 at 09:37:48PM +0100, Hans J. Schultz wrote: >> diff --git a/drivers/net/dsa/mv88e6xxx/chip.h >> b/drivers/net/dsa/mv88e6xxx/chip.h >> index e693154cf803..3b951cd0e6f8 100644 >> --- a/drivers/net/dsa/mv88e6xxx/chip.h >> +++ b/drivers/net/dsa/mv88e6xxx/chip.h >> @@ -280,6 +280,10 @@ struct mv88e6xxx_port { >> unsigned int serdes_irq; >> char serdes_irq_name[64]; >> struct devlink_region *region; >> + >> + /* Locked port and MacAuth control flags */ > > Can you please be consistent and call MAB MAC Authentication Bypass? > I mean, "bypass" is the most important part of what goes on, and you > just omit it. > I must admit that I consider 'MacAuth' and 'Mac Authentication Bypass' to be completely equivalent terms, where the MAB terminology is what is coined by Cisco. Afaik, there is no difference in the core functionality between the two. I do see that Cisco has a more extended concept, when you consider non-core functionality, as how the whole authorization decision process and the infrastructure that is involved works, and thus is very Cisco centered, as I have had in my cover letter: "This feature is known as MAC-Auth or MAC Authentication Bypass (MAB) in Cisco terminology, where the full MAB concept involves additional Cisco infrastructure for authorization." I would have preferred the MacAuth terminology as I see it as more generic and open, but 'mab' is short as a flag name... :D
Powered by blists - more mailing lists