lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 20 Nov 2022 10:33:57 +0100 From: netdev@...io-technology.com To: Vladimir Oltean <olteanv@...il.com> Cc: davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v8 net-next 2/2] net: dsa: mv88e6xxx: mac-auth/MAB implementation On 2022-11-15 23:23, Vladimir Oltean wrote: > > How much (and what) do you plan to add to switchdev.{c,h} in the > future? > It's a bit arbitrary to put only mv88e6xxx_handle_violation() in a file > called switchdev.c. > > port_fdb_add(), port_mdb_add(), port_vlan_add(), port_vlan_filtering(), > etc etc, are all switchdev things. Anyway. > Firstly, those functions you list are ops functions, while what is in switchdev.{c,h} is not, secondly the functions in switchdev.{c,h} are the first to send switchdev messages like SWITCHDEV_FDB_ADD_TO_BRIDGE events. Furthermore I think that chip.c is bloated, but I also do plan to add more to switchdev.{c,h}, and there can be others adding in the future...
Powered by blists - more mailing lists