netdev - Re: [PATCH net-next 1/3] drop_monitor: Implement namespace filtering/reporting for software drops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3uKNf53EkKMmVwh@nanopsycho>
Date:   Mon, 21 Nov 2022 15:24:53 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Nikolay Borisov <nikolay.borisov@...tuozzo.com>
Cc:     nhorman@...driver.com, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org, den@...tuozzo.com,
        khorenko@...tuozzo.com
Subject: Re: [PATCH net-next 1/3] drop_monitor: Implement namespace
 filtering/reporting for software drops

Mon, Nov 21, 2022 at 02:31:30PM CET, nikolay.borisov@...tuozzo.com wrote:

[...]

>diff --git a/include/uapi/linux/net_dropmon.h b/include/uapi/linux/net_dropmon.h
>index 84f622a66a7a..016c36b531da 100644
>--- a/include/uapi/linux/net_dropmon.h
>+++ b/include/uapi/linux/net_dropmon.h
>@@ -8,6 +8,7 @@
> struct net_dm_drop_point {
> 	__u8 pc[8];
> 	__u32 count;
>+	__u32 ns_id;
> };
>
> #define is_drop_point_hw(x) do {\
>@@ -82,6 +83,7 @@ enum net_dm_attr {
> 	NET_DM_ATTR_TRUNC_LEN,			/* u32 */
> 	NET_DM_ATTR_ORIG_LEN,			/* u32 */
> 	NET_DM_ATTR_QUEUE_LEN,			/* u32 */
>+	NET_DM_ATTR_NS,				/* u32 */

I believe that we need to add a CI warning for this kind of UAPI
breakage...


> 	NET_DM_ATTR_STATS,			/* nested */
> 	NET_DM_ATTR_HW_STATS,			/* nested */
> 	NET_DM_ATTR_ORIGIN,			/* u16 */