netdev - Re: [PATCH net-next 1/3] drop_monitor: Implement namespace filtering/reporting for software drops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221121122349.3b217935@kernel.org>
Date:   Mon, 21 Nov 2022 12:23:49 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Nikolay Borisov <nikolay.borisov@...tuozzo.com>,
        nhorman@...driver.com, davem@...emloft.net, pabeni@...hat.com,
        netdev@...r.kernel.org, den@...tuozzo.com, khorenko@...tuozzo.com
Subject: Re: [PATCH net-next 1/3] drop_monitor: Implement namespace
 filtering/reporting for software drops

On Mon, 21 Nov 2022 15:24:53 +0100 Jiri Pirko wrote:
> >+	NET_DM_ATTR_NS,				/* u32 */  
> 
> I believe that we need to add a CI warning for this kind of UAPI
> breakage...

Do you have any ideas on how to code it up in python?
I don't think we let too many such errors thru.

Nikolay, you can't add in the middle of an enum in uAPI because binary
backward compatibility would break. Always add attrs at the end / before
the "cnt" or "max" member.