netdev - Re: [PATCH net-next 00/17] Remove dsa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221121202848.mrtvv6a27qq5ftv6@skbuf>
Date:   Mon, 21 Nov 2022 22:28:48 +0200
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 00/17] Remove dsa_priv.h

On Mon, Nov 21, 2022 at 11:16:07AM -0800, Florian Fainelli wrote:
> This all looks fine on paper, only concern is that it will make our lives so
> much more miserable for back porting fixes into older kernels, if you are
> fine with that as a co-maintainer, then so am I.
> 
> That argument could always be used to make zero re-structuring and it would
> be sad for DSA to ossify, so obviously should not be the major reason for
> not making changes.

I think the opposite of restructuring is not ossification as you say,
but rather disorganized growth which will become even harder to
disentangle later on.

The next step (at some point) is going to be reorganization of what gets
exported to include/net/dsa.h and how, since to me, there's already a
worrying amount of uncontrolled information being scavenged by certain
DSA master drivers, even if the intended recipient for that header is
switch drivers. I didn't start with include/net/dsa.h because, well,
I think first you need to make your own bed before you rule the world,
but in general, what is here can be seen only a small piece of what's to
come.

I'm not sure what to say about backports.. it doesn't scare me too much.
Maybe that's also the lack of experience speaking.