netdev - Re: [PATCH net-next 02/17] net: dsa: modularize DSA_TAG_PROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36728eea-4485-69a6-d4f3-643efd3a8f40@gmail.com>
Date:   Mon, 21 Nov 2022 11:56:33 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 02/17] net: dsa: modularize DSA_TAG_PROTO_NONE

On 11/21/22 05:55, Vladimir Oltean wrote:
> There is no reason that I can see why the no-op tagging protocol should
> be registered manually, so make it a module and make all drivers which
> have any sort of reference to DSA_TAG_PROTO_NONE select it.
> 
> Note that I don't know if ksz_get_tag_protocol() really needs this,
> or if it's just the logic which is poorly written. All switches seem to
> have their own tagging protocol, and DSA_TAG_PROTO_NONE is just a
> fallback that never gets used.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian