netdev - Re: [PATCH net-next 03/17] net: dsa: move bulk of devlink code to devlink.{c,h}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Nov 2022 11:57:24 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 03/17] net: dsa: move bulk of devlink code to
 devlink.{c,h}

On 11/21/22 05:55, Vladimir Oltean wrote:
> dsa.c and dsa2.c are bloated with too much off-topic code. Identify all
> code related to devlink and move it to a new devlink.c file.
> 
> Steer clear of the dsa_priv.h dumping ground antipattern and create a
> dedicated devlink.h for it, which will be included only by the C files
> which need it. Usage of dsa_priv.h will be minimized in later patches.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian