netdev - Re: [PATCH net-next v4 RESEND] stmmac: tegra: Add MGBE support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221122132628.y2mprca4o6hnvtq4@skbuf>
Date:   Tue, 22 Nov 2022 15:26:28 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Bhadram Varka <vbhadram@...dia.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Russell King <linux@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Revanth Kumar Uppala <ruppala@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v4 RESEND] stmmac: tegra: Add MGBE support

On Tue, Nov 22, 2022 at 07:05:22AM +0000, Bhadram Varka wrote:
> Reset values of XPCS IP take care of configuring the IP in 10G mode.
> No need for extra register programming is required from the driver
> side. The only status that the driver expects from XPCS IP is RLU to
> be up which will be done by serdes_up in recent posted changes. Please
> let me know if any other queries on recent changes [0]
> 
> Thank You!
> 
> [0]: https://patchwork.ozlabs.org/project/linux-tegra/patch/20221118075744.49442-2-ruppala@nvidia.com/

What about link status reporting, if the XPCS is connected to an SFP cage?

What I'm trying to get at is that maybe it would be useful to consider
the pcs-xpcs.c phylink pcs driver, even if your XPCS IP is memory mapped,
that is not a problem. Using mdiobus_register(), you can create your own
"MDIO" controller with custom bus read() and write() operations which
translate C45 accesses as seen by the xpcs driver into proper MMIO
accesses at the right address.

If I understand the hardware model right, the XPCS MDIO bus could be
exported by a common, top-level SERDES driver. In addition to the XPCS
MDIO bus, it would also model the lanes as generic PHY devices, on which
you could call phy_set_mode_ext(serdes, PHY_MODE_ETHERNET, phy_mode),
and phy_power_on()/phy_power_off().

Can your SERDES lanes also operate in PCIe mode? If yes, how is the
selection between PCIe and Ethernet/XPCS done?