netdev - Re: [patch V2 12/17] timers: Silently ignore timers with a NULL function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87edttegz8.ffs@tglx>
Date:   Wed, 23 Nov 2022 18:08:27 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Anna-Maria Behnsen <anna-maria@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...uxfoundation.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Julia Lawall <Julia.Lawall@...ia.fr>,
        Arnd Bergmann <arnd@...db.de>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Marc Zyngier <maz@...nel.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        linux-bluetooth@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [patch V2 12/17] timers: Silently ignore timers with a NULL
 function

On Wed, Nov 23 2022 at 12:06, Anna-Maria Behnsen wrote:
> On Tue, 22 Nov 2022, Thomas Gleixner wrote:
>> Add debug_assert_init() instead of the WARN_ON_ONCE(!timer->function)
>> checks so that debug objects can warn about non-initialized timers.
>
> Could you expand this paragraph, so that is is not missleading when a
> reader is not aware of the details of debug objects? Otherwise it seems to
> the reader that debug objects will warn when timer->function == NULL.
>
>   The warning of debug objects does not cover the original
>   WARN_ON_ONCE(!timer->function). It warns when timer was not initialized
>   using timer_setup[_on_stack]() or via DEFINE_TIMER().

Good point.