netdev - Re: [patch V2 07/17] timers: Update kernel-doc for various functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bkoxegxe.ffs@tglx>
Date:   Wed, 23 Nov 2022 18:09:33 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Anna-Maria Behnsen <anna-maria@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...uxfoundation.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Julia Lawall <Julia.Lawall@...ia.fr>,
        Arnd Bergmann <arnd@...db.de>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Marc Zyngier <maz@...nel.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        linux-bluetooth@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [patch V2 07/17] timers: Update kernel-doc for various functions

On Wed, Nov 23 2022 at 11:23, Anna-Maria Behnsen wrote:
>>  /**
>> - * add_timer_on - start a timer on a particular CPU
>> - * @timer: the timer to be added
>> - * @cpu: the CPU to start it on
>> + * add_timer_on - Start a timer on a particular CPU
>> + * @timer:	The timer to be started
>> + * @cpu:	The CPU to start it on
>>   *
>> - * This is not very scalable on SMP. Double adds are not possible.
>> + * This can only operate on an inactive timer. Attempts to invoke this on
>> + * an active timer are rejected with a warning.
>
> This is also true for add_timer(). Is it possible to add this to
> add_timer() function description and just referencing to add_timer()
> function description in add_timer_on()? They behave the same, only
> difference is the CPU where the timer is enqueued.

Indeed.