[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <fc6c11e4-d038-1277-289a-ee51a839fc88@intel.com>
Date: Wed, 23 Nov 2022 10:45:41 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Thomas Gleixner <tglx@...utronix.de>,
LKML <linux-kernel@...r.kernel.org>
CC: Linus Torvalds <torvalds@...uxfoundation.org>,
Steven Rostedt <rostedt@...dmis.org>,
Anna-Maria Behnsen <anna-maria@...utronix.de>,
"Peter Zijlstra" <peterz@...radead.org>,
Stephen Boyd <sboyd@...nel.org>,
"Guenter Roeck" <linux@...ck-us.net>,
Andrew Morton <akpm@...ux-foundation.org>,
"Julia Lawall" <Julia.Lawall@...ia.fr>,
Arnd Bergmann <arnd@...db.de>,
Viresh Kumar <viresh.kumar@...aro.org>,
Marc Zyngier <maz@...nel.org>,
Marcel Holtmann <marcel@...tmann.org>,
Johan Hedberg <johan.hedberg@...il.com>,
"Luiz Augusto von Dentz" <luiz.dentz@...il.com>,
<linux-bluetooth@...r.kernel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
"Jakub Kicinski" <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, <netdev@...r.kernel.org>
Subject: Re: [patch V2 13/17] timers: Split [try_to_]del_timer[_sync]() to
prepare for shutdown mode
On 11/23/2022 9:05 AM, Thomas Gleixner wrote:
> On Tue, Nov 22 2022 at 15:04, Jacob Keller wrote:
>> On 11/22/2022 9:45 AM, Thomas Gleixner wrote:
>>> +int try_to_del_timer_sync(struct timer_list *timer)
>>> +{
>>> + return __try_to_del_timer_sync(timer);
>>> +}
>>> EXPORT_SYMBOL(try_to_del_timer_sync);
>>>
>>
>>
>> Its a bit odd to me that some patches refactor and replace functions
>> with new variants all under timer_* namespace, but then we've left some
>> of them available without that.
>>
>> Any reasoning behind this? I guess "try_*" is pretty clear and unlikely
>> to get stolen by other code..?
>
> Kinda. I renamed del_timer*() because that's the ones which we want to
> substitute with timer_shutdown*() where possible and reasonable.
>
> A larger timer namespace cleanup is subject to a follow up series.
>
> Thanks,
>
> tglx
Yep thats what I figured once I got to the end of the series. Thanks!
Regards,
Jake
Powered by blists - more mailing lists